Skip to content

[v5] Changes to Configuration - CacheOptions (Config #2) #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
May 21, 2025
Merged

[v5] Changes to Configuration - CacheOptions (Config #2) #7697

merged 37 commits into from
May 21, 2025

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Apr 12, 2025 •
edited
Loading

This PR updates the CacheOptions for MSAL Browser v5, including the removal of implementation, tests, and doc references for the following options:

  • temporaryCacheLocation
  • claimsBasedCachingEnabled
  • storeAuthStateInCookie
  • secureCookies
  • cacheMigrationEnabled

Deprecation notices for the above options were added in #7707

@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. msal-browser Related to msal-browser package labels Apr 12, 2025
@github-actions github-actions bot added the msal-common Related to msal-common package label Apr 12, 2025
@jo-arroyo jo-arroyo changed the title [v5] Changes to Configuration - CacheOptions [v5] Changes to Configuration - CacheOptions (Config #2) Apr 14, 2025
@jo-arroyo jo-arroyo marked this pull request as ready for review April 14, 2025 17:03
shylasummers
shylasummers previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@shylasummers shylasummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but somebody else should weigh in on whether to block redirects with memory storage

hectormmg
hectormmg previously approved these changes Apr 16, 2025
View reviewed changes
peterzenz
peterzenz previously approved these changes May 2, 2025
View reviewed changes
sameerag
sameerag previously approved these changes May 2, 2025
View reviewed changes
@jo-arroyo jo-arroyo mentioned this pull request May 21, 2025
Merged
tnorling
tnorling previously approved these changes May 21, 2025
View reviewed changes
@jo-arroyo jo-arroyo requested a review from bgavrilMS as a code owner May 21, 2025 21:07
@jo-arroyo jo-arroyo merged commit 53efb65 into msal-v5 May 21, 2025
8 checks passed
@jo-arroyo jo-arroyo deleted the config-change-cache branch May 21, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@hectormmg hectormmg hectormmg left review comments

@shylasummers shylasummers shylasummers left review comments

@peterzenz peterzenz peterzenz left review comments

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jo-arroyo @hectormmg @tnorling @sameerag @shylasummers @peterzenz